Store synapse's database somewhere other than a volume #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/data is a volume in the Synapse docker image. Volumes are not copied over when committing a container to an image. Thus, we should store the database somewhere else. An alternative fix is to just not create a volume (we don't need it when running complement tests), however this would require creating an separate dockerfile from the one we're using from the Synapse repo now, which is much more annoying.
13 tasks
erikjohnston
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/datais a volume in the Synapse docker image. Volumes are not copiedover when committing a container to an image (this resulted in matrix-org/synapse#8421, where we saw that running Synapse instances seemed to lack the users we had just created on them in the blueprint stage). Thus, we should store the database somewhere else, so that it is copied correctly when a blueprint is used for a single test run.An alternative fix is to just not create a volume (we don't need it when running complement tests), however this would require creating an separate dockerfile from the one we're using from the Synapse repo now, which is much more annoying.